Skip to content

Update for Windows platform. Resolves #18096 #18097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

ag-tafe
Copy link
Contributor

@ag-tafe ag-tafe commented Nov 3, 2024

Fixes #18096

Update of CONTRIBUTING.md document to be able to run tests using Windows OS.

python3 runtests.py

Change to:

python runtests.py
# Use mypy to check mypy's own code
python3 runtests.py self
# or equivalently:
python3 -m mypy --config-file mypy_self_check.ini -p mypy

Change to:

# Use mypy to check mypy's own code
python runtests.py self
# or equivalently:
python -m mypy --config-file mypy_self_check.ini -p mypy

described above to install tox via pip (e.g., python3 -m pip install tox).

Change to:
described above to install tox via pip (e.g., python -m pip install tox).

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this specific to your setup? I haven't heard about python3 being a problem on Windows before.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a Windows programmer for several years -- I can confirm that most Python installations on Windows typically come with a python.exe executable but not a python3.exe executable

@JelleZijlstra
Copy link
Member

The flip side is that on my Mac:

$ python -V
-bash: python: command not found
$ python3 -V
Python 3.13.0

But maybe we can just expect contributors to figure that out.

@hauntsaninja hauntsaninja merged commit 7788c21 into python:master Nov 4, 2024
2 checks passed
@hauntsaninja
Copy link
Collaborator

The instructions still say this for non-Windows, so Mac should be fine:

python3 -m venv venv
source venv/bin/activate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation to reflect running tests on Windows platform
6 participants