Skip to content

Use Python 3.12 for mypy_primer #17456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

hauntsaninja
Copy link
Collaborator

I'd like for us to cover projects that use Python 3.12 only syntax, like homeassistant

I'd like for us to cover projects that use Python 3.12 only syntax
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failure looks spurious if slightly suspicious (bad hash on an attrs package).

Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@hauntsaninja
Copy link
Collaborator Author

Yeah, I think the Azure artifacts thing that Github actions uses is a little sus

@hauntsaninja hauntsaninja merged commit c346c54 into python:master Jul 1, 2024
17 of 18 checks passed
@hauntsaninja hauntsaninja deleted the primer-312 branch July 1, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants