-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Add some initial tests for the fast parser #1648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,13 @@ | |
|
||
from mypy.myunit import main | ||
|
||
# In Python 3.3, mypy.__path__ contains a relative path to the mypy module | ||
# (whereas in later Python versions it contains an absolute path). Because the | ||
# test runner changes directories, this breaks non-toplevel mypy imports. We | ||
# fix that problem by fixing up the path to be absolute here. | ||
import os.path | ||
import mypy | ||
# User-defined packages always have __path__ attributes, but mypy doesn't know that. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Worth filing an issue for. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like there's already one, actually: #1422 |
||
mypy.__path__ = [os.path.abspath(p) for p in mypy.__path__] # type: ignore | ||
|
||
main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
[case testFastParseSyntaxError] | ||
# flags: fast-parser | ||
1 + # E: invalid syntax | ||
|
||
[case testFastParseTypeCommentSyntaxError] | ||
# flags: fast-parser | ||
x = None # type: a : b # E: syntax error in type comment | ||
|
||
[case testFastParseInvalidTypeComment] | ||
# flags: fast-parser | ||
x = None # type: a + b # E: invalid type comment | ||
|
||
-- Function type comments are attributed to the function def line. | ||
-- This happens in both parsers. | ||
[case testFastParseFunctionAnnotationSyntaxError] | ||
# flags: fast-parser | ||
def f(): # E: syntax error in type comment | ||
# type: None -> None | ||
pass | ||
|
||
[case testFastParseInvalidFunctionAnnotation] | ||
# flags: fast-parser | ||
def f(): # E: invalid type comment | ||
# type: (a + b) -> None | ||
pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,6 +57,7 @@ | |
'check-flags.test', | ||
'check-incremental.test', | ||
'check-bound.test', | ||
'check-fastparse.test', | ||
] | ||
|
||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
flake8 | ||
typed-ast |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that this has not occurred before. I guess mypy so far has carefully avoided delayed imports like this. Hopefully once the fast parser is the only parser we can revert this hack (because I feel kind of bad about it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'd prefer to get rid of this hack too. Interestingly, the fast parser is not the only place where we have a delayed import! We also do it in subtypes and strconv. I guess we just don't hit those codepaths in testing? Yikes...