Add support for tuple values on except clauses #1610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| exs3 = (E2, E3) | ||
| try: pass | ||
| except exs3 as e3: | ||
| reveal_type(e3) # E: Revealed type is '__main__.E1' |
There was a problem hiding this comment.
Huh, this is puzzling -- do you understand why it ends up being E1?
There was a problem hiding this comment.
E1 is the nearest common ancestor to E2 and E3, so it is the most specific type that generalizes both.
| @@ -1839,18 +1839,39 @@ def exception_type(self, n: Node) -> Type: | |||
| self.fail('Unsupported exception', n) | |||
| return AnyType() | |||
|
|
|||
| def check_for_function_like_exception_type(self, type: Type, context: Context) -> Type: | |||
There was a problem hiding this comment.
Because this can return None and not only an actual Type, let's annotate as Optional[Type]. PEP 484 specifies that types don't implicitly contain None; we don't quite yet implement that properly in mypy, so we don't catch this, but there's an active PR for it (#1562) and we will soon.
|
Thanks @pdmccormick for the fix! I also appreciate the negative diffstat on application code, and the positive diffstat on test code. :-) |
pdmccormick
added a commit
to pdmccormick/mypy
that referenced
this pull request
Jun 3, 2016
Follow-up to new handling from python#1610.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1590.