Skip to content

(📚) Update comment in Literal example to explain why the redundant overload is needed #14765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

(📚) Update comment in Literal example to explain why the redundant overload is needed #14765

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
132d962
docs: Update comment in `Literal` example to explain why the redundan…
KotlinIsland Feb 23, 2023
e497fc1
Merge branch 'master' into docs/fix_literal_example
KotlinIsland Feb 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/source/literal_types.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ precise type signature for this function using ``Literal[...]`` and overloads:
@overload
def fetch_data(raw: Literal[False]) -> str: ...

# The last overload is a fallback in case the caller
# provides a regular bool:
# The last overload is a fallback due to a limitation in mypy:
# https://github.com/python/mypy/issues/14764

@overload
def fetch_data(raw: bool) -> Union[bytes, str]: ...
Expand Down