[mypyc] Enable native integers outside tests #14606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes native int types `i64`, `i32`, `i16` and `u8`.
JukkaL
added a commit
to mypyc/mypyc-benchmarks
that referenced
this pull request
Feb 4, 2023
This comment has been minimized.
This comment has been minimized.
This requires an ugly hack to also correctly deserialize the native int references in the _promote attribute of `int`, since we modify it during semantic analysis when processing `mypy_extensions`, even though builtins may already have been serialized without this change.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
jhance
approved these changes
Feb 6, 2023
JukkaL
added a commit
to mypyc/mypyc-benchmarks
that referenced
this pull request
Apr 30, 2023
JukkaL
added a commit
to mypyc/mypyc-benchmarks
that referenced
this pull request
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that native integers work well enough to enable them outside tests.
Require a more recent
mypy_extensionsthat includes native int types, includingi64andi32.Add definitions of
i64andi32to the bundled stubs formypy_extensions. Fork the stubs, since the definitions only make sense for mypy/mypyc. They require custom type checking logic. Other tools can treat these as aliases toint, which was implemented here: python/typeshed#9675Also fix serialization of native int TypeInfos. Since we patch
builtins.intwhen we processmypy_extensions, the patched information may not be serialized. We'll also need to perform similar patching during deserialization.Here is the performance impact to some benchmarks when using
i64instead ofinttypes (these assume some additional tweaks that should be ready soon):Perhaps more importantly, native integers help with upcoming low-level features, such as packed arrays.
Closes mypyc/mypyc#837. Remaining work can be tracked in separate issues.