Remove unnecessary build-system entries #14172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyproject.toml:
Remove all unneeded entries from the `build-system` table.
The build-system entries are required for building the wheels and sdist
tarballs of a project [1][2].
They should not include the test and runtime requirements of a project,
which are defined either in setup.py or in in pyproject.toml (in
accordance with PEP0621 [3]).
Only stating the required build system dependencies allows downstream
consumers to properly build and install a project using pypa/build and
pypa/installer.
{build,mypy}-requirements.txt:
Remove unnecessary note about syncing contents with pyproject.toml.
[1] https://peps.python.org/pep-0517/
[2] https://peps.python.org/pep-0518/
[3] https://peps.python.org/pep-0621/
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Closing as per discussion in #14171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyproject.toml:
Remove all unneeded entries from the
build-systemtable. The build-system entries are required for building the wheels and sdist tarballs of a project [1][2].They should not include the test and runtime requirements of a project, which are defined either in setup.py or in in pyproject.toml (in accordance with PEP0621 [3]).
Only stating the required build system dependencies allows downstream consumers to properly build and install a project using pypa/build and pypa/installer.
{build,mypy}-requirements.txt:
Remove unnecessary note about syncing contents with pyproject.toml.
[1] https://peps.python.org/pep-0517/
[2] https://peps.python.org/pep-0518/
[3] https://peps.python.org/pep-0621/
Fixes #14171