Make argument types in function type inference explicitly Optional #1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old version happened to work because an argument would only be omitted when the corresponding formal argument has a Callable type, and in that case constraint generation does isinstance checks on the actual argument type. But calling infer_constraints with actual=None is not really good. (I noticed this while experimenting with moving some Union argument types to the second pass of function type inference.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version happened to work because an argument would only be
omitted when the corresponding formal argument has a Callable type,
and in that case constraint generation does isinstance checks on the
actual argument type. But calling infer_constraints with actual=None
is not really good.
(I noticed this while experimenting with moving some Union argument
types to the second pass of function type inference.)