Compute type of inherited constructor correctly #1376
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good -- assuming that the build passes :-) |
| @@ -359,6 +359,8 @@ def type_object_type(info: TypeInfo, builtin_type: Callable[[str], Instance]) -> | |||
| def type_object_type_from_function(init_or_new: FuncBase, info: TypeInfo, | |||
| fallback: Instance) -> FunctionLike: | |||
| signature = method_type_with_fallback(init_or_new, fallback) | |||
| signature = cast(FunctionLike, | |||
| map_type_from_supertype(signature, info, init_or_new.info)) | |||
There was a problem hiding this comment.
This really deserves a comment, doesn't it.
There was a problem hiding this comment.
Yeah, good point. Maybe some reasoning about why the cast is safe and a general description.
rwbarton
force-pushed
the
rwbarton-init-type
branch
from
aea1971 to
3003e50
Compare
|
Added some comments explaining what is going on here. I don't think the cast really needs a special mention once there is a comment giving the general picture. |
|
Rebased and pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1246.