Don't use an arg type corresponding to ** arg kind as inference context for the argument #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also want to fix the confusing error messages mentioned in #1360 (comment) |
added 2 commits
April 11, 2016 09:36
…hether * or ** was involved. This fixes the issue reported in #1360 (comment) . Specifically, suppose you have these three calls (regardless of how f() is defined!) ``` f(a) f(*a) f(**a) ``` If the type checker determines that there's something wrong with the argument type it always gives the same error message. That error message is appropriate for the first example, `f(a)`, but for the second and third it should at least indicate that the mismatch is due to the star(s) in the call site. I am addressing this by adding one or two stars (as appropriate) in front of the actual type in the error message, so that e.g. instead of ``` Argument 1 to "f" has incompatible type Dict[str, int]; expected "str" ``` you would see ``` Argument 1 to "f" has incompatible type **Dict[str, int]; expected "str" ``` Hopefully this will inform the user that (1) the type of a in `f(**a)` is `Dict[str, int]` and (2) the actual type that doesn't match the expected type "str" is the value slot, in this case `int`. Similar for `*args`.
|
We should really consider refactoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1360.