Implement subtype checking when right-hand side is a generic callable #1340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def fn(n: B) -> None: pass | ||
| def identity(f: A) -> A: | ||
| return f | ||
| identity(fn) |
There was a problem hiding this comment.
Do you want to add a test here that actually tries to call the result too?
There was a problem hiding this comment.
Sounds like a good idea. Added.
This ended up amounting to just removing a check! Fixes python#1236. But something is still not right when using type variables constrained to a list of values; added a failing test for that case.
rwbarton
force-pushed
the
rwbarton-generic-callable
branch
from
5792141 to
7446fc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ended up amounting to just removing a check!
Fixes #1236. But something is still not right when using type
variables constrained to a list of values; added a failing test for
that case.