Improve error message for partial None with --local-partial-types
#12822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When --local-partial-types is set and we can't infer a complete type for a type that we initially inferred as partial None, show an error message that suggests to add a type annotation of the form Optional[<type>].
This comment has been minimized.
This comment has been minimized.
Fix error messages in fine grained tests
This comment has been minimized.
This comment has been minimized.
JukkaL
reviewed
May 20, 2022
This comment has been minimized.
This comment has been minimized.
Code running on Python 3.10 can use PEP 604 annotations, so suggest those instead.
pranavrajpal
force-pushed
the
improve-partial-None-error
branch
from
ed2037b to
c469567
Compare
This comment has been minimized.
This comment has been minimized.
emmatyping
approved these changes
Jun 5, 2022
hauntsaninja
approved these changes
Jul 29, 2022
mypy/messages.py
Outdated
| @@ -1193,18 +1193,30 @@ def need_annotation_for_var(self, node: SymbolNode, context: Context, | |||
| python_version: Optional[Tuple[int, int]] = None) -> None: | |||
| hint = '' | |||
| has_variable_annotations = not python_version or python_version >= (3, 6) | |||
| pep604_supported = python_version and python_version >= (3, 10) | |||
There was a problem hiding this comment.
nit: feels like this should mirror the check for has_variable_annotations when python_version is None
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggest an annotation of the form
Optional[<type>]when we show an error for an inferred partialNonetype (which I think should only happen when--local-partial-typesis set).Should help with merging #10169 (see #10169 (comment)).
Test Plan
The error message in question appeared in a few tests which got changed. I think that should be sufficient to test this since this isn't a particularly complicated change.