Add success msg for only notes output #12306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
jhance
reviewed
Mar 9, 2022
mypy/main.py
Outdated
| @@ -114,13 +114,16 @@ def main(script_path: Optional[str], | |||
| code = 2 if blockers else 1 | |||
| if options.error_summary: | |||
| if messages: | |||
| n_errors, n_files = util.count_stats(messages) | |||
| n_errors, n_notes, n_files = util.count_stats(messages) | |||
There was a problem hiding this comment.
I don't think the outer if remains necessary. If messages is empty, then this returns (0, 0, 0). So we can just always count the stats and then condition on them.
Also, is n_notes == len(messages) actually different from not n_errors? Is there a third type of message that is neither an error nor a note?
There was a problem hiding this comment.
There is a test case [testErrorSummaryOnBadUsage], which generates 'mypy: cannot read file 'missing.py': No such file or directory'
There was a problem hiding this comment.
Okay, I still think the comment about not needing the outer if applies.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12302
The
messageshere could be neither error nor note, thus I modify thecount_statsto also countnote.