Don't use ModuleType.__getattr__ if we know module symbols #11597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/typeshd#6302 added `__getattr__`, but we don't want to always use it, as it can result in undefined references to module attributes being undetected. This is an alternative to python/typeshed#6357. Tested manually with a recent typeshed.
ilevkivskyi
approved these changes
Nov 23, 2021
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
) python/typeshd#6302 added `__getattr__`, but we don't want to always use it, as it can result in undefined references to module attributes being undetected. This is an alternative to python/typeshed#6357. Tested manually with a recent typeshed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python/typeshed#6302 added
__getattr__, but we don't want to alwaysuse it, as it can result in undefined references to module attributes
being undetected.
This is an alternative to python/typeshed#6357.
Tested manually with a recent typeshed.