Skip to content

Editing Contributing.md and adding missing 'v' in the 'activate' word #11474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

noob8boi
Copy link
Contributor

@noob8boi noob8boi commented Nov 5, 2021

Description

This is my first pull request so I am not sure if this is the right way

Fixes #11473

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good.

We generally use less detailed titles for PRs. For example, "Fix typo in CONTRIBUTING.md" would have been sufficient.

@JukkaL JukkaL merged commit 2db0511 into python:master Nov 5, 2021
tushar-deepsource pushed a commit to DeepSourceCorp/mypy that referenced this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CONTRIBUTING.md is missing 'v' in activate
2 participants