Skip to content

Checks Instance and Literal subtypes correctly, refs #11232 #11236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2021
Merged

Checks Instance and Literal subtypes correctly, refs #11232 #11236

merged 3 commits into from
Oct 1, 2021

Conversation

sobolevn
Copy link
Member

Closes #11232
Closes #7399

JukkaL
JukkaL approved these changes Oct 1, 2021
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, such a small change fixes a pretty thorny issue. Thanks!

@JukkaL JukkaL merged commit 967f590 into python:master Oct 1, 2021
@97littleleaf11 97littleleaf11 mentioned this pull request Dec 6, 2021
Closed
@hauntsaninja hauntsaninja mentioned this pull request Dec 10, 2021
Open
@ilevkivskyi ilevkivskyi mentioned this pull request Nov 6, 2022
Open
@hauntsaninja hauntsaninja mentioned this pull request Aug 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boolean literals not recognized as Literals Cannot infer return type if using Union[Tuple[Literal[]]...]
2 participants
@sobolevn @JukkaL