Improve type narrowing for walrus operator in conditional statements #11202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: aioredis (https://github.com/aio-libs/aioredis.git)
- aioredis/client.py:3756: error: Argument 1 to "append" of "list" has incompatible type "Union[bytes, memoryview, str, int, float, None]"; expected "Union[Union[bytes, memoryview], Union[str, int, float]]"
- aioredis/client.py:3771: error: List item 1 has incompatible type "Union[bytes, memoryview, str, int, float, None]"; expected "Union[bytes, str, float]"
- aioredis/client.py:3785: error: List item 1 has incompatible type "Union[bytes, memoryview, str, int, float, None]"; expected "Union[bytes, str, float]"
- aioredis/client.py:3788: error: List item 1 has incompatible type "Union[bytes, memoryview, str, int, float, None]"; expected "Union[bytes, str, float]"
rich (https://github.com/willmcgugan/rich.git)
+ rich/text.py:559: error: Right operand of "or" is never evaluated
+ rich/text.py:563: error: Right operand of "or" is never evaluated
+ rich/text.py:1068: error: Right operand of "or" is never evaluated
+ rich/text.py:1070: error: Right operand of "or" is never evaluated
|
|
Going ahead and merging, since all feedback in the original PR has been addressed. The mypy_primer changes all look correct to me (and seem to be the result of the new fallback case for type maps). |
|
Thank you for this, kprzybyla! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authored by @kprzybyla in #9288. Helps with issue mentioned in #9229.
I fixed some nits and tests, but Github didn't like it when I tried to push to the original branch, so opening a new PR.