Correctly handle cls in protocol classmethod #11119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Sep 20, 2021
| T = TypeVar('T') | ||
|
|
||
| class HasDoX(Protocol): | ||
| @classmethod |
There was a problem hiding this comment.
What about @staticmethod? Does it fall into the same problem?
There was a problem hiding this comment.
staticmethod doesn't have this problem, because there's no self/cls to bind
mypy/subtypes.py
Outdated
| @@ -710,7 +710,7 @@ def find_node_type(node: Union[Var, FuncBase], itype: Instance, subtype: Type) - | |||
| and node.is_initialized_in_class | |||
| and not node.is_staticmethod)): | |||
| assert isinstance(typ, FunctionLike) | |||
| signature = bind_self(typ, subtype) | |||
| signature = bind_self(typ, subtype, isinstance(node, Var) and node.is_classmethod) | |||
There was a problem hiding this comment.
I think that adding argument name here would be better for readability.
There was a problem hiding this comment.
@sobolevn I've added argument name here, is there anything else I can do?
nullie
changed the title
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Closes python#11115. Correctly handle cls in generic classmethods of protocol. This should correctly handle cls in classmethods. Current behavior of not passing is_classmethod seems like an omission in implementation, so this should only correct buggy behavior and shouldn't break something else. Adds a test case `testSelfTypeProtocolClassmethodMatch`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correctly handle cls in generic classmethods of protocol. Closes #11115
This should correctly handle cls in classmethods. Current behavior of not passing is_classmethod seems like an omission in implementation, so this should only correct buggy behavior and shouldn't break something else.
Test Plan
I've included a test in the test suite (testSelfTypeProtocolClassmethodMatch)