Add tests for singledispatch #10627
Merged
Add tests for singledispatch #10627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add mypy tests for singledispatch that represent common errors that we probably want to handle correctly. All of these tests are skipped currently because mypy doesn't properly support singledispatch type checking.
msullivan
approved these changes
Jun 14, 2021
Change the mypy tests to xfails so we realize sooner if they start passing.
|
Related: I am working on It supports even generic functions with type restrictions. It might be useful while working on |
msullivan
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds mypy tests for singledispatch, most of which are either based on the use of singledispatch in stubtest.py or seem like they would be common errors. All of these tests are currently skipped because mypy unsurprisingly doesn't catch these errors yet due to the lack of singledispatch support.
I ended up adding some new error messages for some tests, but I'm not intending for those to be the final error messages that we actually end up using. I just wanted to put something for those errors as a stand-in that we can replace later if anyone has any other preferences.