Skip to content

Add UnionType support when incompatible protocol happens #10154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2021
Merged

Add UnionType support when incompatible protocol happens #10154

merged 2 commits into from
Mar 5, 2021

Conversation

97littleleaf11
Copy link
Collaborator

Description

Fix #10129

Test Plan

Now can generate notes successfully.

@TH3CHARLie TH3CHARLie self-requested a review March 1, 2021 09:58
@97littleleaf11 97littleleaf11 mentioned this pull request Mar 1, 2021
Closed
TH3CHARLie
TH3CHARLie reviewed Mar 1, 2021
View reviewed changes
Copy link
Collaborator

@TH3CHARLie TH3CHARLie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you add a test for this case? you can adopt the code in the related issue.

TH3CHARLie
TH3CHARLie approved these changes Mar 2, 2021
View reviewed changes
Copy link
Collaborator

@TH3CHARLie TH3CHARLie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Looks good to me! @hauntsaninja can you take another look at it?

@TH3CHARLie TH3CHARLie requested a review from hauntsaninja March 2, 2021 23:30
@TH3CHARLie TH3CHARLie merged commit c8bae06 into python:master Mar 5, 2021
hauntsaninja
hauntsaninja reviewed Mar 6, 2021
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late, but lgtm too :-)

@97littleleaf11 97littleleaf11 deleted the incompatible-arg-note-uniontype-support branch May 6, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments

@TH3CHARLie TH3CHARLie TH3CHARLie approved these changes

@henryboisdequin henryboisdequin henryboisdequin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helpful detailed error message on Protocol structural subtyping missing when arg is Optional
4 participants
@97littleleaf11 @hauntsaninja @TH3CHARLie @henryboisdequin