Skip to content

local / in-folder setup.cfg without mypy section shadows any additional user config files #9113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmetz opened this issue Jul 9, 2020 · 0 comments
Labels
feature topic-configuration Configuration files and flags

Comments

@jmetz
Copy link
Contributor

jmetz commented Jul 9, 2020

As the config file read order defined by the order of the lists at https://github.com/python/mypy/blob/master/mypy/defaults.py#L15
is

CONFIG_FILES = CONFIG_FILE + SHARED_CONFIG_FILES + USER_CONFIG_FILES  # type: Final

a shared config file (which may exist for several other purposes) shadows any user config files even in the case when
the shared config file contains no mypy section.

Steps to reproduce:

  • Create an empty setup.cfg in the current directory, and also have one of the USER_CONFIG_FILE versions of a mypy config file.
  • Run mypy
  • Notice that only the setup.cfg file was read, even though it had no mypy section.
    `

Proposal

The logic which checks for a mypy section in the parser object (https://github.com/python/mypy/blob/master/mypy/config_parser.py#L127) should be used to check whether the parser.read call actually loaded anything meaningful from the config file. If no mypy section was loaded, then the loop over the config_files should continue instead of breaking.

This should at least be the case for any shared config files which may exist for entirely other reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature topic-configuration Configuration files and flags
Projects
None yet
Development

No branches or pull requests

2 participants