Skip to content

Unreachable Warning Code #8190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
llchan opened this issue Dec 20, 2019 · 1 comment · Fixed by #8312
Closed

Unreachable Warning Code #8190

llchan opened this issue Dec 20, 2019 · 1 comment · Fixed by #8312
Labels
good-first-issue priority-1-normal topic-usability

Comments

@llchan
Copy link
Contributor

llchan commented Dec 20, 2019 •
edited
Loading

There are sometimes cases where I'd like deliberately put something in a statically-unreachable section---maybe some asserts, maybe some debug info, etc.---in case it does hit that case at runtime. I currently silence them with a # type: ignore[misc] which isn't particularly informative to someone reading the code. Could we give unreachable its own dedicated error/warning code?

EDIT: just so it's clear, I do want to keep the warning on to detect legitimate issues.
@ilevkivskyi
Copy link
Member

Sure, PR is welcome!

@dhalenok dhalenok mentioned this issue Jan 22, 2020
Merged
Michael0x2a pushed a commit that referenced this issue Jan 23, 2020
@dhalenok @Michael0x2a
Add new error code for unreachable errors (#8312)
f3c57e5 
Closes #8190. This introduces a new error code for errors shown when using
the `--warn-unreachable` flag, such as the "Statement is unreachable" error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue priority-1-normal topic-usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new error code for unreachable statement
2 participants
@llchan @ilevkivskyi