Skip to content

New semantic analyzer: plugins #6324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JukkaL opened this issue Feb 4, 2019 · 0 comments
Closed

New semantic analyzer: plugins #6324

JukkaL opened this issue Feb 4, 2019 · 0 comments
Assignees
@ilevkivskyi
Labels
semantic-analyzer Problems that happen during semantic analysis

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Feb 4, 2019

Support plugins with the semantic analyzer. In particular, plugins need to be able to respond to incomplete types and support deferral somehow.
@JukkaL JukkaL added the semantic-analyzer Problems that happen during semantic analysis label Feb 4, 2019
@ilevkivskyi ilevkivskyi self-assigned this Mar 5, 2019
@ilevkivskyi ilevkivskyi mentioned this issue Mar 6, 2019
Merged
ilevkivskyi added a commit that referenced this issue Mar 7, 2019
@ilevkivskyi
Fix dataclass plugin to work with new semantic analyzer (#6515)
892b8d8 
Fixes #6324

This enables two test files that previously had few crashes.

Changes in this PR:
* Add `defer()` to public plugin API, otherwise dataclasses will not works with forward references.
* Update one plugin test to use the new analyzer because the output is a bit more verbose, and probably not worth the hassle of making it identical to old analyzer.
* One test is skipped because of existing issue #6454
* Add the generated type variable used for self types to the class body (this is identical to named tuples and `attrs` plugin).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilevkivskyi ilevkivskyi

Labels
semantic-analyzer Problems that happen during semantic analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JukkaL @ilevkivskyi