-
-
Notifications
You must be signed in to change notification settings - Fork 3k
mypy master fails in typeshed CI #3301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Just traded this back to Ivan's recent Optional cleanup. More to follow. |
This is definitely due to |
Yes, we need to support whatever typing.py is shipped with Python 3.5.1. #ilevkivskyi how soon can you have this fixed? Otherwise I'll just revert #3292 (the culprit). |
I can do this within 30 minutes. |
@JelleZijlstra @gvanrossum Here is PR #3303 that should fix this. Could you please verify that the crash is fixed? Btw, maybe we need to add tests with different versions of |
Thanks Ivan! As for preventing this in the future, the bug apparently doesn't appear with mypy 3.5.1, because that's what mypy's CI uses. Typeshed's CI uses the default Travis version of 3.5, which is 3.5.2. |
Incorrect. The repro I have also uses 3.5.1. As I said above, I suspect that the bug depends on import order within mypy itself and our Travis runs use runtests.py which imports some other modules so the import order problem is avoided. |
I just checked when exactly |
From https://travis-ci.org/python/typeshed/jobs/227972982
Presumably we need to use
'Optional[mypy.types.Type]'
instead? Not sure how this wasn't caught by any of mypy's own tests.The text was updated successfully, but these errors were encountered: