tests not runnable from source release nor after install

[mr-c]

Hello all,

Continuing my work with the Debian package for mypy I am unable to run the tests from the new source package (courtesy #2769) -- looks like runtests.py, test-data, mypy-test isn't included in the MANIFEST.in or setup.py's data_files.

Also, it would be nice to be able to run the tests after installation.

[gvanrossum]

That's so strange. The broken tarball that I had (see #2769) created *did* contain test-data, runtests.py and mypy/test.

[gvanrossum]

Also after upgrading setuptools I managed to create a .tar.gz containing everything you ask for. (See #2769.)

[gvanrossum]

mypy-0.480.dev0.tar.gz

Here's the tarball I got (for the current master), so you can see for yourself.

[mr-c]

@gvanrossum Thanks!

looks like scripts/myunit isn't being included

When I manually copy that in the 143 tasks (3822 tests) run and pass on Debian :-)

[JukkaL]

Is this something that should be fixed, or can we close this issue?

[gvanrossum]

There is the remaining issue about scripts/myunit that needs to be considered. It is currently explicitly excluded, because regular mypy users really have no business running it, and it would just be confusing. It's easily emulated using python3 -m mypy.myunit.

@mr-c Is that sufficient?

[mr-c]

Sure, that works for now.

However, for the tests to be runnable post install many files still need to be included (mypy/test, mypy/test-data at a minimum) and mypy/test/config.py will need to be updated to check $PREFIX/lib/mypy

[gvanrossum]

All those are in the tar.gz file that I attached above -- and that was created by generating a source distribution using the latest setuptools. You should easily be able to verify that from a cloned repo. For the final request can you submit a PR yourself?

[mr-c]

Yep, I can confirm that everything is working for using the source distribution to run the tests -- thanks!

For running the tests after install (and without the source) this will require changes toruntests.py and probably some deeper reflection on how the tests are structured and called. My current branch is at https://github.com/python/mypy/compare/master...mr-c:post-install-testing?expand=1 but it is incomplete.

[gvanrossum]

I don't think it is customary that installing a tool also installs its tests. E.g. for Python IIRC there are separate basic and "dev" packages.

…

On Thu, Feb 9, 2017 at 5:13 AM, Michael R. Crusoe ***@***.***> wrote: Yep, I can confirm that everything is working for using the source distribution to run the tests -- thanks! For running the tests after install (and without the source) this will require changes toruntests.py and probably some deeper reflection on how the tests are structured and called. My current branch is at master...mr-c: post-install-testing?expand=1 but it is incomplete. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2784 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACwrMn_p4PzKU9aoGrl3BQNSw43bLLYPks5raxEUgaJpZM4Lzqnm> .

-- --Guido van Rossum (python.org/~guido)

[mr-c]

Hey @gvanrossum, it doesn't look like any of the source distributions on PyPI for mypy since we talked have actually included the runtests.py, test-data, or mypy-test that your test sdist did: #2784 (comment)

[gvanrossum]

Oops, you're right. When I build a source dist using python3.6 setup.py sdist it produces a tarball including runtests.py, test-data, and docs (but nothing named mypy-test). The tarball on PyPI was created by @JukkaL using a script (misc/upload-pypi.py); maybe there's something broken in his environment that the script doesn't check for? (E.g. an outdated wheel version, which I think was the culprit last time.)

[gvanrossum]

Hm, when I run that script with --force --no-upload 0.511 it also gives me a tarball without runtests.py etc. I suspect that script does something special, but I don't have time to look into it.

[mr-c]

@gvanrossum in #3608 is a fix that works for me.