Skip to content

unknown variable not caught in dict constructor #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ddfisher opened this issue Apr 9, 2016 · 2 comments
Closed

unknown variable not caught in dict constructor #1357

ddfisher opened this issue Apr 9, 2016 · 2 comments
Assignees
@gvanrossum
Labels
bug mypy got something wrong

Comments

@ddfisher
Copy link
Collaborator

ddfisher commented Apr 9, 2016

A file with just

x = dict(undefined_variable)

succeeds, when it should give a Name 'undefined_variable' is not defined error. Without the dict constructor, the error is generated correctly.
@ddfisher ddfisher added this to the 0.3.2 milestone Apr 9, 2016
@ddfisher
Copy link
Collaborator Author

ddfisher commented Apr 9, 2016

And here's why: https://github.com/python/mypy/blob/master/mypy/semanal.py#L1813

@ddfisher ddfisher added the bug mypy got something wrong label Apr 9, 2016
gvanrossum pushed a commit that referenced this issue Apr 9, 2016
When positional args passed to dict(), analyze them. Fix #1357.
41e1349
@gvanrossum gvanrossum self-assigned this Apr 9, 2016
@gvanrossum
Copy link
Member

Decided to fix this, in case it had a bearing on the more complex issue we were investigating yesterday (though I think it doesn't, actually).

gvanrossum pushed a commit that referenced this issue Apr 9, 2016
When positional args passed to dict(), analyze them. Fix #1357.
d91f084
@gvanrossum gvanrossum mentioned this issue Apr 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gvanrossum gvanrossum

Labels
bug mypy got something wrong
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddfisher @gvanrossum