Fix config file parsing of disallow_any/disallow_untyped_defs combination (#4076)

Fixes #4075.

There's a follow-up item to just get rid of `--disallow-any=unannotated` completely, but let's do that together with #4089.

Author: JelleZijlstra

mypy/main.py

@@ -750,7 +750,13 @@ def parse_section(prefix: str, template: Options,
             print("%s: %s: %s" % (prefix, key, err), file=sys.stderr)
             continue
         if key == 'disallow_any':
-            results['disallow_untyped_defs'] = v and 'unannotated' in v
+            # "disallow_any = " should disable all disallow_any options, including untyped defs,
+            # given in a more general config.
+            if not v:
+                results['disallow_untyped_defs'] = False
+            # If "unannotated" is explicitly given, turn on disallow_untyped_defs.
+            elif 'unannotated' in v:
+                results['disallow_untyped_defs'] = True
         if key == 'silent_imports':
             print("%s: silent_imports has been replaced by "
                   "ignore_missing_imports=True; follow_imports=skip" % prefix, file=sys.stderr)

mypy/test/testcmdline.py

@@ -41,7 +41,7 @@ def cases(cls) -> List[DataDrivenTestCase]:
                                   native_sep=True)
         return c
 
-    def run_case(self, testcase: DataDrivenTestCase):
+    def run_case(self, testcase: DataDrivenTestCase) -> None:
         test_python_evaluation(testcase)
 
 

mypy/test/testpythoneval.py

@@ -49,7 +49,7 @@ def cases(cls) -> List[DataDrivenTestCase]:
                     test_python_evaluation, test_temp_dir, True)
         return c
 
-    def run_case(self, testcase: DataDrivenTestCase):
+    def run_case(self, testcase: DataDrivenTestCase) -> None:
         test_python_evaluation(testcase)
 
 

mypy/types.py

@@ -1411,7 +1411,7 @@ def resolve(self, resolved: Type) -> None:
     def accept(self, visitor: 'TypeVisitor[T]') -> T:
         return visitor.visit_forwardref_type(self)
 
-    def serialize(self):
+    def serialize(self) -> str:
         name = self.unbound.name
         # We should never get here since all forward references should be resolved
         # and removed during semantic analysis.

mypy_self_check.ini

@@ -7,6 +7,7 @@ no_implicit_optional = True
 disallow_any = generics, unimported
 warn_redundant_casts = True
 warn_unused_ignores = True
+warn_unused_configs = True
 
 # historical exception
 [mypy-mypy.semanal]
@@ -17,3 +18,7 @@ strict_optional = False
 
 [mypy-mypy.semanal_pass3]
 strict_optional = False
+
+# needs py2 compatibility
+[mypy-mypy.test.testextensions]
+disallow_untyped_defs = False

test-data/unit/cmdline.test

@@ -1078,3 +1078,15 @@ ignore_errors = True
 ignore_errors = False
 [out]
 a/b/c/d/e/__init__.py:1: error: "int" not callable
+
+[case testDisallowUntypedDefsAndGenerics]
+# cmd: mypy a.py
+[file mypy.ini]
+[[mypy]
+disallow_untyped_defs = True
+disallow_any = generics
+[file a.py]
+def get_tasks(self):
+    return 'whatever'
+[out]
+a.py:1: error: Function is missing a type annotation