Skip to content

Tests on Python 3.7 seem to run against stdlib #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaraco opened this issue Oct 21, 2020 · 4 comments
Closed

Tests on Python 3.7 seem to run against stdlib #70

jaraco opened this issue Oct 21, 2020 · 4 comments

Comments

@jaraco
Copy link
Member

jaraco commented Oct 21, 2020

In GitLab by @jaraco on Jun 2, 2019, 12:09

While developing, I've been running tox -e py37-cov, but I find that the tests pass even when I disable crucial functionality. I suspect what's happening is the tests are running against stdlib on Python 3.7. This library should always run against its local implementation on any Python (even 3.8+). Tests against any stdlib implementation should run in that repo's test suite.

@jaraco
Copy link
Member Author

jaraco commented Oct 21, 2020

In GitLab by @warsaw on Jun 2, 2019, 12:59

I ran into this too, and had forgotten I’d done it this way. I totally agree.

signature.asc

@jaraco
Copy link
Member Author

jaraco commented Oct 21, 2020

In GitLab by @jaraco on Jan 17, 2020, 21:47

mentioned in merge request !83

@jaraco
Copy link
Member Author

jaraco commented Oct 21, 2020

In GitLab by @jaraco on Jan 18, 2020, 07:47

closed via merge request !83

@jaraco
Copy link
Member Author

jaraco commented Oct 21, 2020

In GitLab by @jaraco on Jan 18, 2020, 07:47

mentioned in commit ce2fa42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant