Add how to review and comment on GitHub #188
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
requested changes
May 5, 2017
| @@ -322,6 +322,9 @@ code and leave comments in the pull request or issue tracker. | |||
| However, please be aware that if you are recommending a pull request as | |||
| 'merge-ready', you should always make sure the entire test suite passes. | |||
|
|
|||
| 7. You may also review and comment the pull requests on GitHub, for how to | |||
There was a problem hiding this comment.
"comment on the pull request on GitHub (for how ..."
|
It should be mentioned that #186 is still being discussed as to whether we want to link to GitHub or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit mention GItHub review step at the end of
How to Review a Pull Request.Close #186