Skip to content

Consistently use 'gc_ref' in the garbage collector docs #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

Consistently use 'gc_ref' in the garbage collector docs #1029

merged 1 commit into from
Jan 18, 2023

Conversation

pablogsal
Copy link
Member

Closes: #1026

@gvanrossum
Copy link
Member

Oh, maybe we should consistently use gc_refs? In gcmodule.c there's a variable named that and mentioned frequently in docs.

@JelleZijlstra
Copy link
Member

There is a diagram somewhere that says gc_ref and Pablo said somewhere he didn't want to redraw it.

@CAM-Gerlach
Copy link
Member

There is a diagram somewhere that says gc_ref and Pablo said somewhere he didn't want to redraw it.

In #1026 (comment) , BTW

@CAM-Gerlach CAM-Gerlach changed the title Use consistently 'gc_ref' in the garbage collector docs Consistently use 'gc_ref' in the garbage collector docs Jan 18, 2023
@pablogsal pablogsal merged commit 9513ac8 into python:main Jan 18, 2023
@pablogsal
Copy link
Member Author

If I manage to get some time I can give a go at doing the images again but meanwhile I will merge this. Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Garbage collector article makes mixed use of gc_ref and gc_refs
4 participants
@pablogsal @gvanrossum @JelleZijlstra @CAM-Gerlach