-
-
Notifications
You must be signed in to change notification settings - Fork 847
Add a "Patterns" chapter #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
GitMate.io thinks possibly related issues are python/core-workflow#189 (Add CONTRIBUTING.md), #3 (Add Travis support), #172 (Add PDF build), #136 (Add a chapter for introducing common function / class' corresponding source file), and python/core-workflow#32 (Add the mention bot?). |
Why are we converting an accurate |
@ncoghlan good catch my example comes from I could fix it in I am going to fix my PR with your recommendation in CPython: https://github.com/python/cpython/pull/11945/files#diff-e85eca61cec5281c45f14cd6819bf548L1766 Thank you |
Ok I have fixed my PR python/cpython#11945 Thank you |
I think this is out of scope for the devguide. Patterns like this are a general thing for the wider community and should be covered elsewhere, e.g. blog posts or the documentation. |
Yesterday, I have fixed an issue in bpo and this issue was for the support of
os.PathLike
inFileCookieJar
. Since the introduction ofos.PathLike
and__fspath__
, we continue to convert some parts of code to beos.PathLike
compliant and I think there is a pattern for that.Maybe we could create a page "Patterns" with some examples.
For example (but need to be tested and approved)
How to support a
os.PathLike
object?The text was updated successfully, but these errors were encountered: