Skip to content

Imprecision in compiler.rst #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
psyker156 opened this issue Sep 15, 2018 · 1 comment
Closed

Imprecision in compiler.rst #417

psyker156 opened this issue Sep 15, 2018 · 1 comment

Comments

@psyker156
Copy link
Contributor

When adding a new opcode, if the guide is followed as is, the following error will be emitted as regen-importlib expects the new opcode target to be present in ceval.c before the command is added.

gcc -pthread -c -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -Werror=implicit-function-declaration -I. -I./Include -DPy_BUILD_CORE -o Python/ceval.o Python/ceval.c In file included from Python/ceval.c:629:0: Python/ceval.c: In function ‘_PyEval_EvalFrameDefault’: Python/opcode_targets.h:119:5: error: label ‘TARGET_LOAD_BUILTIN’ used but not defined &&TARGET_LOAD_BUILTIN, ^ Makefile:1613: recipe for target 'Python/ceval.o' failed make: *** [Python/ceval.o] Error 1

I have already created a pull request for this. Please see #416

@Mariatta
Copy link
Member

GitMate.io thinks possibly related issues are #181 (A couple of issues with compiler.rst), #199 (Improve "Commit Messages" section in committing.rst), #170 (Who is BCP at developers.rst), #44 (Update committing.rst for Git/GitHub), and #50 (Update index.rst for Git/GitHub).

AA-Turner pushed a commit to AA-Turner/devguide that referenced this issue Jun 17, 2022
Closes python#417.

* Update compiler.rst for more precision about new opcode

* Update compiler.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants