Skip to content

gh-99970 Adding missing optionflags parameter in the documentation of doctest #99971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

busywhitespace
Copy link
Contributor

@busywhitespace busywhitespace commented Dec 3, 2022

Adding optionflags parameter into the signature of DocTestSuite function.

See #99970 for more details.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

Docstring of DocTestSuite indeed has it:

cpython/Lib/doctest.py

Lines 2389 to 2390 in bf26bdf

optionflags
A set of doctest option flags expressed as an integer.

And **options passed to DocTestCase does not have any extra kwargs:

cpython/Lib/doctest.py

Lines 2172 to 2173 in bf26bdf

def __init__(self, test, optionflags=0, setUp=None, tearDown=None,
checker=None):

@kumaraditya303 kumaraditya303 changed the title gh-99970 Adding a missing parameter in the documentation of doctest gh-99970 Adding missing optionflags parameter in the documentation of doctest Dec 10, 2022
@kumaraditya303 kumaraditya303 merged commit e477348 into python:main Dec 10, 2022
@kumaraditya303
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants