[3.8] gh-98433: Fix quadratic time idna decoding. (GH-99092) (GH-99222) #99231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) (pythonGH-99222) There was an unnecessary quadratic loop in idna decoding. This restores the behavior to linear. (cherry picked from commit d315722) (cherry picked from commit a6f6c3a) Co-authored-by: Miss Islington (bot) <[email protected]> Co-authored-by: Gregory P. Smith <[email protected]>
bedevere-bot
added
type-bug
gpshead
changed the title
gpshead
approved these changes
Nov 8, 2022
|
Sorry, I can't merge this PR. Reason: |
|
@ambv: Would you mind to merge this security fix? It's already in other branches, including 3.7 ;-) |
|
@ambv : is there a plan for when the next 3.8 release might be cut? I noticed that this item wasn't in .15; Blackduck is already citing this as an issue, so the need for resolving this in cpython and trickling the fix down will need to come sooner rather than later. |
|
Release manager conversations recently suggest they'll be coordinating releases for the week of December 5th. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an unnecessary quadratic loop in idna decoding. This restores
the behavior to linear.
(cherry picked from commit d315722)
(cherry picked from commit a6f6c3a)
Co-authored-by: Miss Islington (bot) [email protected]
Co-authored-by: Gregory P. Smith [email protected]