[3.11] gh-98783: Fix crashes when str subclasses are used in _PyUnicode_Equal (GH-98806)
#98869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code_Equal` (pythonGH-98806) (cherry picked from commit 76f989d) Co-authored-by: Nikita Sobolev <[email protected]>
sweeneyde
reviewed
Oct 30, 2022
| @@ -1144,7 +1144,7 @@ PyAPI_FUNC(PyObject*) _PyUnicode_FromId(_Py_Identifier*); | |||
| and where the hash values are equal (i.e. a very probable match) */ | |||
| PyAPI_FUNC(int) _PyUnicode_EQ(PyObject *, PyObject *); | |||
|
|
|||
| /* Equality check. Returns -1 on failure. */ | |||
| /* Equality check. */ | |||
There was a problem hiding this comment.
Actually, in 3.11, this can return -1 on failure.
There was a problem hiding this comment.
I can backport manually without this comment change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 76f989d)
Co-authored-by: Nikita Sobolev [email protected]
int.from_bytescrashes ifbyteorderis a string subclass #98783