Fix mistakes on function coroutines related definitions #9871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to clarify: while async def statements are the preferred way to create routines, generator-based routines still exist (asyncio.coroutine). While generator-based coroutines are slated for removal in 3.10, I think the right thing to do is to be precise about what type of coroutines we are talking about. |
willingc
reviewed
Oct 14, 2018
Doc/reference/compound_stmts.rst
Outdated
| @@ -707,16 +707,16 @@ Coroutine function definition | |||
| keyword: await | |||
|
|
|||
| Execution of Python coroutines can be suspended and resumed at many points | |||
| (see :term:`coroutine`). In the body of a coroutine, any ``await`` and | |||
| (see :term:`coroutine`). In the body of a coroutine function, any ``await`` and | |||
Doc/reference/compound_stmts.rst
Outdated
| It is a :exc:`SyntaxError` to use ``yield from`` expressions in | ||
| ``async def`` coroutines. | ||
| It is a :exc:`SyntaxError` to use a ``yield from`` expression inside an | ||
| ``async def`` statement. |
There was a problem hiding this comment.
Would it be better to use function body instead of statement?
There was a problem hiding this comment.
Yes, I like it better :)
There was a problem hiding this comment.
I'll do a small rewording, let me know if it is ok.
asvetlov
approved these changes
Oct 28, 2018
|
Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-10170 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 28, 2018
Fix a bug I introduced in pythonGH-9864 by which coroutines are treated as synonymous of function coroutines. Also, fix the same mistake (coroutines == function coroutines) already present in other parts of the reference. I'm very sorry for the hassle. (cherry picked from commit 95f68b1) Co-authored-by: Andrés Delfino <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 28, 2018
Fix a bug I introduced in GH-9864 by which coroutines are treated as synonymous of function coroutines. Also, fix the same mistake (coroutines == function coroutines) already present in other parts of the reference. I'm very sorry for the hassle. (cherry picked from commit 95f68b1) Co-authored-by: Andrés Delfino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug I introduced in #9864 by which coroutines are treated as synonymous of function coroutines.
Also, fix the same mistake (coroutines == function coroutines) already present in other parts of the reference.
I'm very sorry for the hassle.