-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Correct some typos in comments #98194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Community policy in general is not to merge pull requests fixing typos. |
@musvaage I don't understand what you are saying. The policy (Cpython) is that there is no need to create an Github Issue an a News entry for such simple changes. |
A core dev stated [context being source code files] that was policy. Modules/pyexpat.c - * messages with libexpat and (by definiton) in bulletproof sync
+ * messages with libexpat and (by definition) in bulletproof sync That typo was revealed among others Aug 13. 2022 in Issue |
I have no opinion whether or not this PR should be merged; merely reiterating Community policy as was explained to me. |
@musvaage is correct that we don't really want to encourage this kind of PR, as typos in comments don't really have any impact on end users, and PRs like this distract from more important issues. But since you've already made the PR, I'm okay with merging it. |
Status check is done, and it's a success ✅. |
Comment noted. That being said, .h files might be considered as more exposed than .c files.
|
Automerge-Triggered-By: GH:AlexWaygood