Skip to content

Correct some typos in comments #98194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2022
Merged

Correct some typos in comments #98194

merged 2 commits into from
Nov 6, 2022

Conversation

jonasdlindner
Copy link
Contributor

@jonasdlindner jonasdlindner commented Oct 11, 2022

Automerge-Triggered-By: GH:AlexWaygood

@ghost
Copy link

ghost commented Oct 11, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@musvaage musvaage mentioned this pull request Oct 11, 2022
@musvaage
Copy link
Contributor

Community policy in general is not to merge pull requests fixing typos.

@jonasdlindner
Copy link
Contributor Author

jonasdlindner commented Oct 11, 2022

@musvaage I don't understand what you are saying. The policy (Cpython) is that there is no need to create an Github Issue an a News entry for such simple changes.

@musvaage
Copy link
Contributor

musvaage commented Oct 12, 2022

don't understand

@jonasdlindner

A core dev stated [context being source code files] that was policy.


Modules/pyexpat.c

-      *       messages with libexpat and (by definiton) in bulletproof sync
+      *       messages with libexpat and (by definition) in bulletproof sync

That typo was revealed among others Aug 13. 2022 in Issue #95969 (Closed).

@musvaage
Copy link
Contributor

I have no opinion whether or not this PR should be merged; merely reiterating Community policy as was explained to me.

@AlexWaygood
Copy link
Member

@musvaage is correct that we don't really want to encourage this kind of PR, as typos in comments don't really have any impact on end users, and PRs like this distract from more important issues. But since you've already made the PR, I'm okay with merging it.

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit ede6cb2 into python:main Nov 6, 2022
@musvaage
Copy link
Contributor

musvaage commented Nov 6, 2022

@AlexWaygood

Comment noted.

That being said, .h files might be considered as more exposed than .c files.

$ python3 --version
Python 3.9.15
$ find /usr/include/python3.9 -type f | wc -l
176
$ 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants