-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-98030: socket: add missing TCP socket options #98031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
19f8cc6
to
90f954b
Compare
A few TCP socket options have been added to the Linux kernel these last few years. This commit adds all the ones available in Linux 6.0: https://elixir.bootlin.com/linux/v6.0/source/include/uapi/linux/tcp.h#L91 While at it, the TCP_FASTOPEN option has been moved lower in the list just to keep the same order as in tcp.h to ease future synchronisations. Please note that I initially wanted to get socket.TCP_FASTOPEN_CONNECT. I was going to add only this one but while at it, here are all the missing ones. Signed-off-by: Matthieu Baerts <[email protected]>
90f954b
to
dc82784
Compare
✅ Deploy Preview for python-cpython-preview canceled.
|
Signed-off-by: Matthieu Baerts <[email protected]>
dc82784
to
e88ecc3
Compare
Hi @gpshead, Thank you for the review! I'm sorry for the delay, I missed the notification when I was on holiday. I just listed all new constants in the doc as requested. Feel free to tell me if it is not what you had in mind! |
|
A few TCP socket options have been added to the Linux kernel these last few years.
This commit adds all the ones available in Linux 6.0:
https://elixir.bootlin.com/linux/v6.0/source/include/uapi/linux/tcp.h#L91
While at it, the
TCP_FASTOPEN
option has been moved lower in the list just to keep the same order as intcp.h
to ease future synchronisations.Please note that I initially wanted to get
socket.TCP_FASTOPEN_CONNECT
. I was going to add only this one but while at it, here are all the missing ones.