Skip to content

bpo-34921: No return not allowed by get_type_hints; line 133 … #9750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2018
Merged

bpo-34921: No return not allowed by get_type_hints; line 133 … #9750

merged 2 commits into from
Oct 8, 2018

Conversation

NoahGWood
Copy link
Contributor

@NoahGWood NoahGWood commented Oct 7, 2018

bpo-34921: Modified line 133 in Lib/typing.py to fix get_type_hints(NoReturn)

https://bugs.python.org/issue34921

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one minor style comment, otherwise looks good. Also please sign the CLA.

@ilevkivskyi ilevkivskyi changed the title Fixed issue 34921: No return not allowed by get_type_hints; line 133 … bpo-34921: No return not allowed by get_type_hints; line 133 … Oct 7, 2018
@gvanrossum gvanrossum removed their request for review October 7, 2018 20:36
@ilevkivskyi
Copy link
Member

It looks like something is wrong with CLA bot. I checked on https://check-python-cla.herokuapp.com/ that the CLA is signed few hours ago, but the label is still red. I am going to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants