Adjust stable ABI internal documentation #96896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(This is just a documentation tweak to an internal file, so I've skipped filing an issue. But let me know if you'd like me to.) |
|
Thank you! |
I think so! Thanks for doing that! |
Document struct_abi_kind & members
encukou
approved these changes
Oct 4, 2022
|
Sorry, I can't merge this PR. Reason: |
|
Thanks @woodruffw for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-97828 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 4, 2022
I was perusing this file, and noticed that this part of the documentation is slightly out of date: the `struct` items in this TOML file currently contain `struct_abi_kind` members, which distinguish between the different types of ABI compatibility described in the comment. I've updated the comment to reflect this. (cherry picked from commit 6e53308) Co-authored-by: William Woodruff <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 4, 2022
I was perusing this file, and noticed that this part of the documentation is slightly out of date: the `struct` items in this TOML file currently contain `struct_abi_kind` members, which distinguish between the different types of ABI compatibility described in the comment. I've updated the comment to reflect this. (cherry picked from commit 6e53308) Co-authored-by: William Woodruff <[email protected]>
pablogsal
pushed a commit
that referenced
this pull request
Oct 22, 2022
I was perusing this file, and noticed that this part of the documentation is slightly out of date: the `struct` items in this TOML file currently contain `struct_abi_kind` members, which distinguish between the different types of ABI compatibility described in the comment. I've updated the comment to reflect this. (cherry picked from commit 6e53308) Co-authored-by: William Woodruff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was perusing this file, and noticed that this part of the documentation is slightly out of date: the
structitems in this TOML file currently containstruct_abi_kindmembers, which distinguish between the different types of ABI compatibility described in the comment.I've updated the comment to reflect this.
Automerge-Triggered-By: GH:encukou