Skip to content

gh-96773 Fixing documentation of socket backlog #96778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mehrdadmoradii
Copy link
Contributor

@mehrdadmoradii mehrdadmoradii commented Sep 12, 2022

making the socket.create_server docs consistent with socket.listen.

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 12, 2022
@mehrdadmoradii mehrdadmoradii changed the title Fixing documentation of socket backlog gh-96773 Fixing documentation of socket backlog Sep 13, 2022
@slateny
Copy link
Contributor

slateny commented Sep 24, 2022

Change seems right and matches with #12735, just uncertain on whether it will truly set backlog to 0, or if sys/socket also sets some default on its end.

@giampaolo Could you take a look at this PR and whether it looks good to you, or if it needs something on backlog=0?

@kumaraditya303 kumaraditya303 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 1, 2023
@kumaraditya303 kumaraditya303 merged commit 1d1480f into python:main Jan 1, 2023
@miss-islington
Copy link
Contributor

Thanks @mehrdadmoradii for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 1, 2023
(cherry picked from commit 1d1480f)

Co-authored-by: Mehrdad Moradizadeh <[email protected]>
@bedevere-bot
Copy link

GH-100661 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 1, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 1, 2023
(cherry picked from commit 1d1480f)

Co-authored-by: Mehrdad Moradizadeh <[email protected]>
@bedevere-bot
Copy link

GH-100662 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 1, 2023
miss-islington added a commit that referenced this pull request Jan 1, 2023
(cherry picked from commit 1d1480f)

Co-authored-by: Mehrdad Moradizadeh <[email protected]>
miss-islington added a commit that referenced this pull request Jan 1, 2023
(cherry picked from commit 1d1480f)

Co-authored-by: Mehrdad Moradizadeh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants