Docs: group sqlite3.Connection attributes and methods #96090
Conversation
erlend-aasland
added
skip issue
needs backport to 3.11
bedevere-bot
added
docs
There was a problem hiding this comment.
IMO, it makes sense to list attributes before methods as you do, but just to note, the Cursor class right below it has the opposite order. Given it should be consistent (especially in Reference documentation), do you plan to follow this up with a PR moving those as well? Or would you like me to?
Yes, I noticed. Consistency is a good thing. Feel free to submit a PR for that. |
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
Thanks for the reviews! |
|
GH-96110 is a backport of this pull request to the 3.11 branch. |
|
GH-96111 is a backport of this pull request to the 3.10 branch. |
(cherry picked from commit 1a140af) Co-authored-by: Erlend E. Aasland <[email protected]>
(cherry picked from commit 1a140af) Co-authored-by: Erlend E. Aasland <[email protected]>
(cherry picked from commit 1a140af) Co-authored-by: Erlend E. Aasland <[email protected]>
(cherry picked from commit 1a140af) Co-authored-by: Erlend E. Aasland <[email protected]>
|
Reading through the docs in their current form, I wonder if it was a mistake to put the connection attributes before the connection methods; for your everyday sqlite3 programming, I suspect you'll be using the connection methods way more often than you'll be using the connection attributes. I think we should consider putting the methods before the attributes. |
|
Yeah, I'd prepped a PR to do the above a few weeks ago when we discussed it, but got second thoughts for the same reason you mention and never went through with it. |
No description provided.