Skip to content

gh-94430: Allow parameters named module or self with custom C names in Argument Clinic #94431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 7, 2022
Merged

gh-94430: Allow parameters named module or self with custom C names in Argument Clinic #94431

merged 6 commits into from
Jul 7, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 29, 2022 •
edited by bedevere-bot
Loading

@erlend-aasland erlend-aasland linked an issue Jun 29, 2022 that may be closed by this pull request
AC: Params named module with custom C names are rejected #94430
Closed
@erlend-aasland
Copy link
Contributor Author

cc. @arhadthedev

@erlend-aasland erlend-aasland changed the title gh-94430: Allow self parameters with custom C names in Argument Clinic gh-94430: Allow parameters named module or self with custom C names in Argument Clinic Jun 29, 2022
@erlend-aasland erlend-aasland marked this pull request as draft June 29, 2022 20:55
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jun 29, 2022 •
edited
Loading

Unfortunately, the fix is not as simple as this. UPDATE: See 4a45b6f for a better solution.

@arhadthedev arhadthedev mentioned this pull request Jun 29, 2022
Closed
@erlend-aasland erlend-aasland marked this pull request as ready for review June 29, 2022 21:40
@arhadthedev arhadthedev mentioned this pull request Jul 1, 2022
Merged
arhadthedev added a commit to arhadthedev/cpython that referenced this pull request Jul 1, 2022
@arhadthedev
Redefine module parameter as proposed in pythongh-94431
c85bbfb
@erlend-aasland
Copy link
Contributor Author

@JelleZijlstra, what do you think? Is this change worth it?

erlend-aasland
erlend-aasland commented Jul 3, 2022
View reviewed changes
@erlend-aasland erlend-aasland requested a review from eryksun July 3, 2022 21:41
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jul 5, 2022 •
edited
Loading

@ambv, since we're into Argument Clinic (again); would you mind looking at this PR as well? The change itself is pretty straight-forward, but I'm not sure if it is worth it. The only possible enhancement might be to leave an explanatory comment.

IMO, it makes sense to apply this bco. correctness, even though the amount of use-cases is low. I'd like another core dev's opinion before landing it, though.

erlend-aasland
erlend-aasland commented Jul 5, 2022
View reviewed changes
@erlend-aasland
Copy link
Contributor Author

IIRC, we backport AC changes. Adding 3.11 and 3.10 labels.

@erlend-aasland erlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 6, 2022
@erlend-aasland
Copy link
Contributor Author

A pair of hearts and no thumbs down hints to some enthusiasm 🙂 Unless someone complains, I'll merge this next week. Reviews are still welcome.

kumaraditya303
kumaraditya303 reviewed Jul 7, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this would be useful in #92891

@erlend-aasland
Copy link
Contributor Author

Thanks for the review, Kumar.

@erlend-aasland erlend-aasland merged commit 8bbd70b into python:main Jul 7, 2022
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @erlend-aasland, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8bbd70b4d130f060f87e3f53810dc747a49fa369 3.11

@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8bbd70b4d130f060f87e3f53810dc747a49fa369 3.10

@erlend-aasland erlend-aasland deleted the ac-param-module branch July 7, 2022 09:32
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 7, 2022
@erlend-aasland
[3.11] pythongh-94430: Allow params named module or self with cus…
1f11087 
…tom C names in Argument Clinic (pythonGH-94431)

(cherry picked from commit 8bbd70b)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@kumaraditya303 kumaraditya303 added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jul 7, 2022
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 7, 2022
@bedevere-bot
Copy link

GH-94649 is a backport of this pull request to the 3.11 branch.

@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @erlend-aasland, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8bbd70b4d130f060f87e3f53810dc747a49fa369 3.11

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 7, 2022
@erlend-aasland
[3.10] pythongh-94430: Allow params named module or self with cus…
6720e7f 
…tom C names in Argument Clinic (pythonGH-94431).

(cherry picked from commit 8bbd70b)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 7, 2022
@bedevere-bot
Copy link

GH-94650 is a backport of this pull request to the 3.10 branch.

@erlend-aasland erlend-aasland mentioned this pull request Jul 7, 2022
Closed
erlend-aasland added a commit that referenced this pull request Jul 7, 2022
@erlend-aasland
[3.11] gh-94430: Allow params named module or self with custom C …
c0b7868 
…names in AC (GH-94431) (#94649)

(cherry picked from commit 8bbd70b)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jul 7, 2022
@erlend-aasland
[3.10] gh-94430: Allow params named module or self with custom C …
dc36801 
…names in AC (GH-94431) (#94650)

(cherry picked from commit 8bbd70b)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

@eryksun eryksun Awaiting requested review from eryksun

Assignees

@erlend-aasland erlend-aasland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AC: Params named module with custom C names are rejected
4 participants
@erlend-aasland @miss-islington @bedevere-bot @kumaraditya303