Skip to content

gh-91243: Document Required and NotRequired #93173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 27, 2022

Conversation

davidfstr
Copy link
Contributor

No description provided.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 24, 2022
@JelleZijlstra JelleZijlstra added skip news 3.11 only security fixes needs backport to 3.11 only security fixes and removed 3.11 only security fixes labels May 24, 2022
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few notes:

@davidfstr
Copy link
Contributor Author

Thanks for taking a look @AlexWaygood ! I did apply the suggested wordsmith changes.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more tiny nits, sorry!

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@miss-islington
Copy link
Contributor

Thanks @davidfstr for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-93303 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2022
Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit 711eda7)

Co-authored-by: David Foster <[email protected]>
miss-islington added a commit that referenced this pull request May 27, 2022
Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit 711eda7)

Co-authored-by: David Foster <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news topic-typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants