gh-89158: Add some REPL secondary prompt markers #93073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue on tutorial/classes.rst section 9.4 where the example "class Warehouse" was truncated when pressing the >>> button to hide the prompts and output.
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
@Gaasmann Have you signed the CLA yet? The CLA seems 'stuck'. Will close/open to try to trigger it. This PR makes Warehouse consistent with the previous Complex class above. It should fix the bug. The alternative would be to make it consistent with class Dog above. I don't care. I agree with skipping news item. I adjusted title and commit message. Thank you for making PR. |
terryjreedy
added
needs backport to 3.10
terryjreedy
approved these changes
May 22, 2022
|
Thanks @Gaasmann for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-93087 is a backport of this pull request to the 3.11 branch. |
|
GH-93088 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 23, 2022
This fixes an issue on tutorial/classes.rst section 9.4 where the example "class Warehouse" was truncated when pressing the >>> button to hide the prompts and output. (cherry picked from commit 88f0d0c) Co-authored-by: Nicolas Haller <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 23, 2022
This fixes an issue on tutorial/classes.rst section 9.4 where the example "class Warehouse" was truncated when pressing the >>> button to hide the prompts and output. (cherry picked from commit 88f0d0c) Co-authored-by: Nicolas Haller <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 23, 2022
This fixes an issue on tutorial/classes.rst section 9.4 where the example "class Warehouse" was truncated when pressing the >>> button to hide the prompts and output. (cherry picked from commit 88f0d0c) Co-authored-by: Nicolas Haller <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 23, 2022
This fixes an issue on tutorial/classes.rst section 9.4 where the example "class Warehouse" was truncated when pressing the >>> button to hide the prompts and output. (cherry picked from commit 88f0d0c) Co-authored-by: Nicolas Haller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue on tutorial/classes.rst section 9.4 where the example "class Warehouse"
was truncated when pressing the >>> button to hide the prompts and output.
#89158