gh-92986: Make level of ImportFrom not optional on ASDL #92987
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a news entry at the very least and also an entry in what's new as this is technically backwards incompatible no? Users not passing this in will be broken by the change if I am not mistaken |
|
Yes, it is backwards incompatible (although in practice looks like people pass it). But looks like we have a test for allowing None https://bugs.python.org/issue13436: Line 1112 in e8e737b Maybe we should close this and change ast.unparse instead? |
That would be my recommendation |
hauntsaninja
added a commit
to hauntsaninja/cpython
that referenced
this pull request
May 19, 2022
This doesn't happen naturally, but is allowed by the ASDL and compiler. We don't want to change ASDL for backward compatibility reasons (python#57645, python#92987)
|
Okay, opened a PR for ast.unparse at #92992 |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 5, 2022
…GH-92992) This doesn't happen naturally, but is allowed by the ASDL and compiler. We don't want to change ASDL for backward compatibility reasons (pythonGH-57645, pythonGH-92987) (cherry picked from commit 200c9a8) Co-authored-by: Shantanu <[email protected]>
isidentical
pushed a commit
that referenced
this pull request
Sep 5, 2022
isidentical
pushed a commit
to isidentical/cpython
that referenced
this pull request
Sep 5, 2022
…ythonGH-92992) This doesn't happen naturally, but is allowed by the ASDL and compiler. We don't want to change ASDL for backward compatibility reasons (pythonGH-57645, pythonGH-92987) (cherry picked from commit 200c9a8) Co-authored-by: Shantanu <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Sep 5, 2022
This doesn't happen naturally, but is allowed by the ASDL and compiler. We don't want to change ASDL for backward compatibility reasons (GH-57645, GH-92987) (cherry picked from commit 200c9a8) Co-authored-by: Shantanu <[email protected]>
isidentical
added a commit
that referenced
this pull request
Sep 6, 2022
) (GH-96593) This doesn't happen naturally, but is allowed by the ASDL and compiler. We don't want to change ASDL for backward compatibility reasons (GH-57645, GH-92987) (cherry picked from commit 200c9a8) Co-authored-by: Shantanu <[email protected]> Co-authored-by: Shantanu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.