-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-91491: Complete Whats New in 3.11 for typing #92708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0a9eb32
gh-91491: Complete Whats New in 3.11 for typing
JelleZijlstra c0d95b4
Update Doc/whatsnew/3.11.rst
JelleZijlstra b244db8
Merge branch 'main' into whatsnew
JelleZijlstra 8798089
feedback
JelleZijlstra c242df1
Update Doc/whatsnew/3.11.rst
JelleZijlstra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we really include this? It's a private undocumented function (though David's recent bug report suggested to me otherwise).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that it's already spawned a bug report, it's likely that other users will run into this change, so I think it's important to include.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed then. Could you please add a notice strongly discouraging users from using it too? We might as well try to dissuade users though it might be in vain :).
This function is for internal use only and is **unstable** and may change across versions. Please do not use this function. Instead, we recommend implementing this with your own code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That feels like a bit much for the What's New document. We should say what changed, but I don't think we need more than that.