-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-92417: socket
docs: remove references to Python <3.3
#92544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please don't backport any of these. Only actual bug fixes should be back ported. |
The devguide (https://devguide.python.org/gh-labels/?highlight=backport) says "Generally, backports to the maintenance branches are primarily bugfixes and documentation clarifications." This is a documentation clarification, so it seems fine to backport it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this. We still keep versionchanged
directives for versions >= 3.0 in docs. Even if nobody currently uses Python 3.2, the old (and still working) code can have references to IOError.
That's a good point.
|
chunk
docs, socket
docs: remove references to Python <3.3socket
docs: remove references to Python <3.3
3.9 is now security fixes only so that solved itself. Whether it makes sense to backport to 3.10, in general we are backporting docs changes that apply to older versions as not doing so leads to needless conflicts later on if some bugfix is applied that touches docs. So I'd backport to 3.10, too, as we're already doing for 3.11. |
Thanks @AlexWaygood for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
GH-92968 is a backport of this pull request to the 3.11 branch. |
GH-92969 is a backport of this pull request to the 3.10 branch. |
…onGH-92544) (cherry picked from commit 639b62c) Co-authored-by: Alex Waygood <[email protected]>
…onGH-92544) (cherry picked from commit 639b62c) Co-authored-by: Alex Waygood <[email protected]>
Thanks @ambv! |
#92417