Skip to content

gh-92417: socket docs: remove references to Python <3.3 #92544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2022

Conversation

AlexWaygood
Copy link
Member

@rhettinger
Copy link
Contributor

Please don't backport any of these. Only actual bug fixes should be back ported.

@rhettinger rhettinger removed needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels May 9, 2022
@JelleZijlstra
Copy link
Member

The devguide (https://devguide.python.org/gh-labels/?highlight=backport) says "Generally, backports to the maintenance branches are primarily bugfixes and documentation clarifications." This is a documentation clarification, so it seems fine to backport it.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this. We still keep versionchanged directives for versions >= 3.0 in docs. Even if nobody currently uses Python 3.2, the old (and still working) code can have references to IOError.

@AlexWaygood
Copy link
Member Author

I am not sure about this. We still keep versionchanged directives for versions >= 3.0 in docs. Even if nobody currently uses Python 3.2, the old (and still working) code can have references to IOError.

That's a good point. IOError isn't mentioned anywhere else in the chunk docs, so I'll revert those changes. (chunk is also now deprecated, so probably not worth worrying about.)

socket.error is documented elsewhere in the module, though, so I think it makes sense to remove the note in the socket docs. Do you agree?

@AlexWaygood AlexWaygood changed the title gh-92417: chunk docs, socket docs: remove references to Python <3.3 gh-92417: socket docs: remove references to Python <3.3 May 10, 2022
@ambv
Copy link
Contributor

ambv commented May 19, 2022

3.9 is now security fixes only so that solved itself. Whether it makes sense to backport to 3.10, in general we are backporting docs changes that apply to older versions as not doing so leads to needless conflicts later on if some bugfix is applied that touches docs. So I'd backport to 3.10, too, as we're already doing for 3.11.

@ambv ambv added the needs backport to 3.10 only security fixes label May 19, 2022
@ambv ambv merged commit 639b62c into python:main May 19, 2022
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-92968 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 19, 2022
@bedevere-bot
Copy link

GH-92969 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 19, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2022
@AlexWaygood AlexWaygood deleted the old-errors branch May 19, 2022 15:26
@AlexWaygood
Copy link
Member Author

Thanks @ambv!

ambv pushed a commit that referenced this pull request May 19, 2022
ambv pushed a commit that referenced this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants