Use percentage over factor for whatsnew in 3.11 performance claim #92496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fidget-Spinner
added
needs backport to 3.11
Fidget-Spinner
changed the title
|
Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-92498 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 8, 2022
) (cherry picked from commit 9304f98) Co-authored-by: Ken Jin <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 8, 2022
(cherry picked from commit 9304f98) Co-authored-by: Ken Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realised that "1.25x faster" might confuse casual readers. IMO to make things as clear as possible, it should either be a "1.25x speedup" (this term is well established in computer science literature) or "25% faster".
In contrast, the summary at the top of What's New uses "1.25x speedup":