Skip to content

[3.9] gh-92417: doctest docs: remove references to Python <3.6 (GH-92420) #92492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.9] gh-92417: doctest docs: remove references to Python <3.6 (GH-92420) #92492

wants to merge 1 commit into from

Conversation

miss-islington
Copy link
Contributor

(cherry picked from commit 5639ea1)

Co-authored-by: Alex Waygood [email protected]

@miss-islington miss-islington force-pushed the backport-5639ea1-3.9 branch from 784ea4b to ef289e0 Compare May 8, 2022 16:01
@miss-islington
Copy link
Contributor Author

@AlexWaygood and @serhiy-storchaka: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request May 8, 2022
Merged
@miss-islington
Copy link
Contributor Author

@AlexWaygood and @serhiy-storchaka: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@AlexWaygood and @serhiy-storchaka: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot added skip news docs Documentation in the Doc dir awaiting review labels May 8, 2022
@AlexWaygood AlexWaygood mentioned this pull request May 8, 2022
Closed
@miss-islington
Copy link
Contributor Author

@AlexWaygood and @serhiy-storchaka: Status check is done, and it's a success ✅ .

CAM-Gerlach
CAM-Gerlach reviewed May 8, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Apparently I can't delete this comment, but I immediately realized I'd been on the wrong tab and accidentally submitted a review on a backport PR right after submitting it instead of the main one. My fault, sorry.)

@AlexWaygood
Copy link
Member

It looks like there's a chunk of text referring to compatibility with Python <3.2, and workarounds to support Python <2.4, in the description of doctest.EXCEPTION_DETAIL; should that be elided as well? It substantially complicates the description of doctest.IGNORE_EXCEPTION_DETAIL and doesn't seem to be of any use for modern Python, beyond what is already noted in the versionchanged notice.

Let's discuss that over at the issue (#92417) rather than in the comment thread for a backport PR :-)

@CAM-Gerlach
Copy link
Member

Yes, I'd realized immediately after submitting it but couldn't delete my review, so I ended up just editing it instead. Really sorry about that, I'm a doofus.

@AlexWaygood
Copy link
Member

Yes, I'd realized immediately after submitting it but couldn't delete my review, so I ended up just editing it instead. Really sorry about that, I'm a doofus.

No reason to be sorry! I'm sure miss-islington appreciates the review :-)

@AlexWaygood AlexWaygood requested a review from JelleZijlstra May 9, 2022 07:52
@rhettinger
Copy link
Contributor

Please don't backport these. That is only appropriate for a bug fix.

@rhettinger rhettinger closed this May 9, 2022
@miss-islington miss-islington deleted the backport-5639ea1-3.9 branch May 9, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees
No one assigned
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @AlexWaygood @CAM-Gerlach @rhettinger @bedevere-bot